approvals/ApprovalTests.Java

ReporterWithApprovalPower result is ignored when using FileApprover with PackageSettings or annotations

Opened this issue · 0 comments

When the reporter configuration is controlled via PackageSettings or annotations the FileApprover will always ignore the result of the defined ReporterWithApprovalPower.

In fact, the top-level reporter when using PackageSettings or annotations is always a FirstWorkingReporter:

return FirstWorkingReporter.combine(getFrontLoadedReporter(), returned);

Due to this the instanceof check inside the FileApprover


will always be false when the reporter is configured with settings/annotations.