appsignal/appsignal-nodejs

Update `@opentelemetry/api`, remove `@opentelemetry/api-metrics`

unflxw opened this issue · 8 comments

unflxw commented

On npm i @appsignal/nodejs:

npm WARN deprecated @opentelemetry/api-metrics@0.33.0: Please use @opentelemetry/api >= 1.3.0

We should update our dependencies.

tombruijn commented

I think this is because of our local overrides. Package @opentelemetry/instrumentation version 0.34.0 doesn't have this dependency anymore. Can we remove the override @unflxw ?

unflxw commented

Probably! If the tests pass without it then we're good.

tombruijn commented

@unflxw can you do a quick test of that?

unflxw commented

It's not the overrides' fault (though I'll submit a PR to remove them anyway)

Prisma instrumentation has not updated its dependencies on @opentelemetry/instrumentation and @opentelemetry/api for a while -- the first one brings in the deprecated @opentelemetry/api-metrics.

Submitted a PR to Prisma: prisma/prisma#17198

  • 👍1
tombruijn commented

Prisma PR and our PR merged. Closing.

unflxw commented

@tombruijn Should we keep this open until there's a Prisma release and we can upgrade to it?

  • 👍1
unflxw commented

Closed by #842.