CLI is NOT respecting telemetry opt-out
bruteforks opened this issue · 3 comments
Describe the bug
exporting SB_TELEMETRY_DISABLED=1 via zshrc and the CLI sends telemetry
SB_TELEMETRY_DISABLED=1 pnpm saas command and the CLI sends telemetry
even SB_TELEMETRY_DISABLED=0 pnpm saas still sends telemetry
Steps to reproduce
Add your own honeycomb API key, and watch the telemetry data roll into honeycomb.io
System Info
no thanksLogs
No response
Validations
- Follow our Code of Conduct.
- Read the Contributing Guidelines.
- Read the docs.
- Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
- Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
Thanks for addressing it! Also https://github.com/apptension/create-saas-boilerplate/ suffers from the same issue.
@mkleszcz Have you tested this? It's still not respecting user's preferences.
@bruteforks yes, I have tested it and did it once again now. For me it's working as expected: when there is SB_TELEMETRY_DISABLED env variable set to 1 no data is sent and there is no info about telemetry. Are you sure that you pulled latest changes? If you are using create script this fix will be available on the latest release.
Also please do not duplicate issues. For the create script there is a separate repository with separate issues.