apptentive/apptentive-android

(android:maxSdkVersion="18") for WRITE_EXTERNAL_STORAGE

gmbett opened this issue · 9 comments

gmbett commented

On latest Apptentive version you added the above attribute.

That property breaks the permission request process for those applications that are targeting API 26 and are requesting READ_EXTERNAL_STORAGE and WRITE_EXTERNAL_STORAGE storage permissions.

https://developer.android.com/about/versions/oreo/android-8.0-changes#rmp

gmbett commented

It can be fixed if you add:

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="replace"/>

But anyway... you shouldn't do that

weeeBox commented

Hi @gmbett,

It was added in version 5.1.4. Doesn't it work for you as expected?

gmbett commented

If I don't add the tools:node="replace" the permission request fails immediately.

weeeBox commented

Sorry for the inconvenience. We'll look at it and get back to you.

weeeBox commented

Hi @gmbett,

We're trying to reproduce the issue on our end. Would you be able to provide more implementation details (like your build.gradle file or even a small test project). That would be very helpful!

gmbett commented

Hi @weeeBox

I have created a sample project to show you the issue.
Please check: https://github.com/gmbett/storagepermissionissue

If you have any questions please feel free to ask them !

weeeBox commented

Thanks!

weeeBox commented

Hi @gmbett,

I can see the issue now. It seems like other lib developers are experiencing this, too. We would update our docs and ask people to override permission in their manifest:

<uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" tools:node="replace"/>

This article explains it better: https://commonsware.com/blog/2018/04/09/manifest-merger-maxsdkversion-missing-permission.html

gmbett commented

Ok, thanks for checking this issue. 👍