Unlock a next key only when the previous keys are also above the target speed broken
Closed this issue · 9 comments
Unlock a next key only when the previous keys are also above the target speed feature broken by latest commit "feat: cling to the unlocked key" This feature seems to have been nullified by this commit.
But I think I tested it thoroughly. I wrote a lot of unit tests to better understand the new change. I also manually went through the keys to see it with my eyes.
Can you please elaborate what's wrong with the new change? It should behave as follows:
- When you unlock a new key, focus stays on this key until you reach the target speed. Focus never shifts to any other key.
- When you finally reach the target speed, two outcomes are possible:
2.1. If Unlock a next key only when... is disabled, then a new key is unlocked and focused.
2.2. If Unlock a next key only when... is enabled, then the focus shifts to a previous key with the least typing speed.
2.2.1. Once you reach the target speed for all the current keys again, then a new key is unlocked.
I've noticed a change as well. The number of unlocked keys went down. I had an additional 5-6 keys that were unlocked before the update.
In scenario 2.2 new keys keep getting unlocked even if a previous key is below the threshold
Here M was unlocked after P reached the threshold even though C is below the threshold and this never happened before this update. Always needed to get all previous chars above the threshold
In scenario 2.2 new keys keep getting unlocked even if a previous key is below the threshold
Here M was unlocked after P reached the threshold even though C is below the threshold and this never happened before this update. Always needed to get all previous chars above the threshold
I see that you have unlocked a few keys ahead of the time. And it seems like these keys were falsely included into lessons.
Let me think about this case.
I've noticed a change as well. The number of unlocked keys went down. I had an additional 5-6 keys that were unlocked before the update.
The new algorithm might not work well with the keys unlocked ahead of the time. Can you please share your profile with me? You can send it to me on the Discord server, or to info@keybr.com.
Gee I thought it would be much simpler.
Thanks a lot. The scores from these keys are from trying out a different mode (not the normal lesson mode) but they never bothered me or caused any problems. Thanks in advance for looking into it
Always a special case. Sorry for breaking the algorithm and thanks for your time :)
I have published a new version of keybr to the Internet with a change that might fix at least a part of this bug.
I have not yet committed it to the repository, because the fix is dirty.
I'll keep working on it and hope to fix all problems soon.
I have reverted the recent changes. Things should go back to where they were before.