arai-a/ditm

Saved and Used menu are not working

Closed this issue · 3 comments

karlcow commented
  1. With Firefox Nightly 90.0a1 (2021-05-29) (64-bit) on macOS 11.4 (20F71)
  2. Go to https://www.mozilla.org/en-US/
  3. Open developer tools
  4. Click on DITM icon
  5. Click on Select URL to load (Used)

Expected:
List of URLs

Actual:
Menu is not responsive.

Notes:

  • Same are erasing and installing the addon again
  • Same with Firefox Nightly 91.0a1 (2021-05-31) (64-bit)
  • Using Version: 1.5.0 Last Updated: June 2, 2021

Browser Console Error:

08:24:20.209 TypeError: can't access property "getFullZoomForBrowser", ZoomManager is undefinedSelectParent.jsm:784:1
    receiveMessage resource://gre/actors/SelectParent.jsm:784
    (Async: JSActor query)
    showDropDown resource://gre/actors/SelectChild.jsm:128
    SelectContentHelper resource://gre/actors/SelectChild.jsm:64
    handleEvent resource://gre/actors/SelectChild.jsm:447

Capture d’écran 2021-06-02 à 08 25 14

         let { ZoomManager } = topBrowsingContext.topChromeWindow;
         SelectParentHelper.populate(
           menulist,
           data.options.options,
           data.options.uniqueStyles,
           data.selectedIndex,
           // We only want to apply the full zoom. The text zoom is already
           // applied in the font-size.
           ZoomManager.getFullZoomForBrowser(browser),
           data.defaultStyle,
           data.style
         );

aka ZoomManager.getFullZoomForBrowser(browser)

arai-a commented

Thank you for reporting!

reproduced the issue, and it seems to be reproducible only when the devtools is in the separate window.
I also observed the error for getFullZoomForBrowser there.

temporary workaround is to put the devtools in the main browser window (meatball menu -> "Dock to Bottom").

will investigate the issue.

arai-a commented

Fixed on m-c: https://hg.mozilla.org/mozilla-central/rev/d93dbe2a3c9c
Will be available from Firefox 91 and 91 ESR

  • 👍1