Logging breaks on Crystal 0.34.0

[lebogan]

This is a known breaking change due to the Log module rewrite.

[arcage]

Thanks.

I will fix it in this week end.

[arcage]

I released v0.5.0 that fits the new Log module.

To do this, some change occured on the logging functions.

Could you check the new one?

[lebogan]

Thank you very much. Logging now works with email in my app. I will close?

[Nicolab]

Hello,

I have this issue with v0.6.0.
v0.6.0 does not include this fix? https://github.com/arcage/crystal-email/blob/v0.6.0/src/email.cr#L2

[arcage]

v0.6.0 also supports new Log mechanism.
The new "log" module is required at https://github.com/arcage/crystal-email/blob/v0.6.0/src/email/client.cr#L2 .
But, I had forgotten the removing that line.

I will remove that line in next release ASAP.
Thank you pointed out it

And, at least in my environment, this issue had been solved after v0.5.0(also v0.6.0), and the compiler occurred no errors even if the require "logger" line exists.
Because, old Logger module is not removed in crystal 0.34.0 yet, but only in "Deprecated" status now.

Could you tell me the details of this issue in your environment?

[Nicolab]

Great, thanks 👍

Because, old Logger module is not removed in crystal 0.34.0 yet, but only in "Deprecated" status now.
Could you tell me the details of this issue in your environment?

Yes, there is hundreds lines of deprecation warning.

[arcage]

I released v0.6.1 that removes it.
Could you try it?

Deprecation warning will be occurred only when the old Logger object is used.
But, this shard uses no Logger object in the code base after v0.5.0.

I wonder why those warnings were occurred. 🤔

[Nicolab]

Indeed, sorry! After searching on the Logger instance and not on the name of the package (logger), it's Granite that causes this. :/

I have upgraded to 0.6.1. So it's totally made for crystal-email. 👍
Thank you for your reactivity, nice!