archiecobbs/ivyroundup

jdom, apache commons configuration, madura configuration

Closed this issue · 10 comments

Please add these three products to your repository.
I have attached the patch files after testing the updates locally.

jdom and apache configuration are well known.
madura configuration is my own o/s product which depends on those two,
among others which you already have.

Thanks.
Roger 

Original issue reported on code.google.com by roger.parkinson35 on 27 Feb 2010 at 11:59

Attachments:

I've added jdom and commons-configuration in r1071.. thanks.

The madura ivy.xml contains "compile" and "test" configurations.. this stuff is
"private" to that project and should not be part of the "public" ivy file.

Please remove "private" configurations and dependencies from the ivy file and 
attach
an updated patch. Thanks.

Please see also http://code.google.com/p/ivyroundup/wiki/HowToContribute , e.g.,
patch files should be against and svn copy of the boilerplate files, etc.

Original comment by archie.c...@gmail.com on 1 Mar 2010 at 4:14

  • Changed state: Accepted
  • Added labels: Type-Enhancement
  • Removed labels: Type-Defect
Thanks for jdom and commond-configuration and thanks for the feedback.
I have removed the configurations and replaced them with one (default) which 
seems to
be in line with other ones I found. The patch is attached.

Thanks again.
Roger

Original comment by roger.parkinson35 on 2 Mar 2010 at 5:16

Attachments:

I get this error. Is your SHA1 checksum wrong? I get
3ec9a425c3084c12140f5248fd096f6225230b14 instead of
331697030bc8dfc40f515852f2189cdc9bd7c389.


[ivy:resolve] download.1.N10016:                                                


[ivy:resolve]                                                                   


[ivy:resolve]       [get] Getting:
http://maduraconfiguration.googlecode.com/files/maduraconfiguration-2.2.zip     


[ivy:resolve]                                                                   


[ivy:resolve]       [get] To:
/home/archie/.ivy2/packager/cache/maduraconfiguration-2.2.zip                   


[ivy:resolve]                                                                   


[ivy:resolve] ....................................................              


[ivy:resolve] .......                                                           


[ivy:resolve]                                                                   


[ivy:resolve] checkdownload.1.N10016:                                           


[ivy:resolve]                                                                   


[ivy:resolve]                                                                   


[ivy:resolve] download.N10016:                                                  


[ivy:resolve]                                                                   


[ivy:resolve]
/home/archie/projects/ivyroundup/trunk/build/resolve/build/workspace/nz.co.senan
que/maduraconfiguration/2.2/build.xml:53:
The following error occurred while executing this line:                         



[ivy:resolve]
/home/archie/projects/ivyroundup/trunk/build/resolve/build/workspace/nz.co.senan
que/maduraconfiguration/2.2/packager-output.xml:46:
SHA1 checksum verification for maduraconfiguration-2.2.zip failed!              



Original comment by archie.c...@gmail.com on 2 Mar 2010 at 4:50

  • Changed state: Feedback
Sorry about that, I think I overwrote the zip file or something.
I've gone over it again anyway to get the source dirs in there and tested 
(again)
Thanks for your patience.
R

Original comment by roger.parkinson35 on 3 Mar 2010 at 12:03

Attachments:

Your checksum changed yet again (now it's 
0ab33f8332402d5c3a13f0c4fbd2cab5d8c0748a,
which is different from your patch).

Also your module fails with this error, because you are trying to expand a file 
which
you didn't download:

[ivy:resolve]
/home/archie/projects/ivyroundup/trunk/build/resolve/build/workspace/nz.co.senan
que/maduraconfiguration/2.2/build.xml:53:
The following error occurred while executing this line:                         



[ivy:resolve]
/home/archie/projects/ivyroundup/trunk/build/resolve/build/workspace/nz.co.senan
que/maduraconfiguration/2.2/packager-output.xml:59:
Error while expanding
/home/archie/projects/ivyroundup/trunk/build/resolve/build/workspace/nz.co.senan
que/maduraconfiguration/2.2/archive/maduraconfiguration-javadocs-2.2.zip

[ivy:resolve] java.io.FileNotFoundException:
/home/archie/projects/ivyroundup/trunk/build/resolve/build/workspace/nz.co.senan
que/maduraconfiguration/2.2/archive/maduraconfiguration-javadocs-2.2.zip
(No such file or directory)

Plus your patch is still not an svn diff against the boilerplate files.

Please re-read the "how to contribute" guidelines and test your addition before
resubmitting.

The build process is not perfect (nor perfectly easy to understand) so I'm 
happy to
answer any questions... please email them to the mailing list (Google group). 
Thanks.

Original comment by archie.c...@gmail.com on 3 Mar 2010 at 2:45

I think I found the difference from the boilerplate files and fixed that now.
Also I managed to send you the wrong patch file earlier, sorry.
So, yet again, this one is a tested patch for version 2.6
I hope I got it right this time.

Original comment by roger.parkinson35 on 3 Mar 2010 at 6:03

Attachments:

I also checked the SHA1 numbers and they look like they agree now ie he SHA1 on 
the
file in the downloads on my project agrees with the number in my packager.xml. 
As
long as I don't overwrite that file (one of the earlier problems) it should 
still
agree when you get to it. So I won't.

Original comment by roger.parkinson35 on 3 Mar 2010 at 8:36

Please let me know if there's more I need to do on this. I believe #6 has fixed 
all
the outstanding issues (from #5) now and am waiting on you. Thanks.

Original comment by roger.parkinson35 on 6 Mar 2010 at 8:22

Thanks... I'm out of town right now but will take a look when I get back next 
week.

Original comment by archie.c...@gmail.com on 7 Mar 2010 at 12:49

Madura configuration added in r1099.

Original comment by archie.c...@gmail.com on 8 Mar 2010 at 9:45

  • Changed state: Fixed