ardaku/whoami

Question: Why change to non-exhaustive language model?

Opened this issue · 2 comments

Why move from whoami::lang() which returned a Vec to whoami::langs() which returns Vec if the enum Language isn't using close to an exhaustive list? Having only English, Spanish and __ to represent other's seems like it would further complicate language matching downstream.

The plan is to eventually make the enum include all ISO 639-1 language codes, but has not been prioritized

It is just an internal detail at the moment, usage should be fine using .to_string() for any language / country combination