Mask is not reflected in help output
idefixcert opened this issue · 11 comments
idefixcert commented
Is it intentional that masked field values are printed during the help output?
--db-password/$CLOUD-API_DB_PASSWORD (default: postgres)
ardan-bkennedy commented
Actually I missed that in the help message. Hahaha
We need to get that fixed and have mask and noprint respect the help output as well.
idefixcert commented
Hey Bill,
happy do help with this,
let me work on a MR.
Chris
…On Thu, 14 Apr 2022 at 14:57, William Kennedy ***@***.***> wrote:
Actually I missed that in the help message. Hahaha
We need to get that fixed and have mask and noprint respect the help
output as well.
—
Reply to this email directly, view it on GitHub
<#27 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOH4Z3ZGBZX33KKF7TUWM3VFAI3XANCNFSM5TNBUKHQ>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
Thanx Chris
----
Dipl.-Ing. Chris Lenz
http://www.freelenzer.at
ardan-bkennedy commented
That would be brilliant.
ardan-bkennedy commented
@idefixcert did you ever work on this?
idefixcert commented
No, I didn't.
There was no time so far.
🙈
William Kennedy ***@***.***> schrieb am Sa. 19. Nov. 2022 um
22:14:
@idefixcert <https://github.com/idefixcert> did you ever work on this?
—
Reply to this email directly, view it on GitHub
<#27 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAOH4ZZIOLAK2YEQKQ7HMSLWJE7LDANCNFSM5TNBUKHQ>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
Thanx Chris
----
Dipl.-Ing. Chris Lenz
http://www.freelenzer.at
claudemuller commented
Hey @ardan-bkennedy and @idefixcert - is it kewl if I take a stab at fixing this issue?
ardan-bkennedy commented
@claudemuller sure
claudemuller commented
Hey @ardan-bkennedy
I've added a PR for this issue. When you have a moment, I'd love your feedback :)
ardan-bkennedy commented
It might take till the end of the day or tomorrow, but I will look at this before the end of the week! Thanks!
claudemuller commented
No worries :) Thanks!
ardan-bkennedy commented
Fixed!!