ardatan/graphql-import

Add missing test cases for fix #32

Closed this issue · 1 comments

kbrandwijk commented
Add missing test cases for fix #32
SpaceK33z commented

I wanted to write a PR for this (to better understand how this package works), but this is fixed already. I commented out the one-line fix from #32, and the "importSchema: directive" test failed.

Raw output as proof;

✖ importSchema: directive Error thrown in test

  1 test failed

  importSchema: directive

  /Users/kees/dev/graphql-import/src/definition.ts:56

   55:     newTypeDefinitions.push(...collectedTypedDefinitions)
   56:     definitionPool.push(...collectedTypedDefinitions)
   57:

  Error thrown in test:

  Error {
    message: 'Directive upper: Couldn\'t find type upper in any of the schemas.',
  }

  collectDirective (src/definition.ts:56:54)
  collectNode (src/definition.ts:56:54)
  src/definition.ts:53:7
  collectNewTypeDefinitions (src/definition.ts:49:39)
  Object.completeDefinitionPool (src/definition.ts:9:645)
  Object.importSchema (src/index.ts:45:58)
  Test.fn (src/index.test.ts:356:8)
  processEmit (node_modules/nyc/node_modules/signal-exit/index.js:155:32)
  processEmit (node_modules/nyc/node_modules/signal-exit/index.js:155:32)

So this issue can be closed :).

  • 🎉1