arduino-libraries/ArduinoModbus

Incorrect conversion of seconds and micro seconds to milliseconds

r2park opened this issue 2 years ago · 1 comments

r2park commented 2 years ago

https://github.com/arduino-libraries/ArduinoModbus/blob/0cee633cb267962e1cf0a780b8028e049656b0da/src/libmodbus/modbus-tcp.cpp#L838C62-L838C62

ArduinoModbus/src/libmodbus/modbus-rtu.cpp

Line 1262 in 0cee633

    
           unsigned long wait_time_millis = (tv == NULL) ? 0 : (tv->tv_sec * 1000) + (tv->tv_usec / 1000);

facchinm commented 2 years ago

It is correct, since struct timeval is defined as https://renenyffenegger.ch/notes/development/languages/C-C-plus-plus/C/libc/structs/timeval . So if you have tv defined as tv = { .tv_sec = 5; .tv_usec = 34000; } the number of milliseconds will be 5*1000 + 34000/1000