arduino-libraries/ArduinoMqttClient

Giga R1 WiFi works with a small change

esp32beans opened this issue · 3 comments

esp32beans commented

I tested ver 0.1.6 using Giga R1 WiFi. Only a small change is required to make the examples work. I removed the check for ESP32 because Giga also uses WiFi.h.

Old

#elif defined(ESP32)
  #include <WiFi.h>
#endif

New

#else
  #include <WiFi.h>
#endif

Is it too much to hope new boards will implement the standard Arduino WiFi API? For example, Uno R4 will have a WiFi option. Would be nice to avoid releasing a new version of the library whenever a new board with WiFi appears.

aentinger commented

I've fixed this library.

It would probably pay off to do a new release of this library, any objections @pennam ?

pennam commented

Not at all. Thanks @aentinger 👍