arduino/setup-protoc

Warning: The `add-path` command is deprecated and will be disabled soon

g4s8 opened this issue · 7 comments

g4s8 commented

Hi!

We're using this project to setup protobuf compiler in Github actions: https://github.com/cqfn/degitx/blob/master/.github/workflows/ci.yaml

But it shows warnings on each build:

Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/

It seems this action uses some deprecated Github API.

The fill logs is here: https://github.com/cqfn/degitx/runs/1220350933?check_suite_focus=true

Run arduino/setup-protoc@master
  with:
    version: 3.x
    include-pre-releases: false
  env:
    GOROOT: /opt/hostedtoolcache/go/1.14.7/x64
Getting protoc version: v3.13.0
Downloading archive: https://github.com/protocolbuffers/protobuf/releases/download/v3.13.0/protoc-3.13.0-linux-x86_64.zip
/home/runner/work/_actions/arduino/setup-protoc/master/node_modules/@actions/tool-cache/scripts/externals/unzip /home/runner/work/_temp/0d981901-170a-4c18-a300-71739a12a21d
Archive:  /home/runner/work/_temp/0d981901-170a-4c18-a300-71739a12a21d
   creating: include/
   creating: include/google/
   creating: include/google/protobuf/
  inflating: include/google/protobuf/wrappers.proto  
  inflating: include/google/protobuf/field_mask.proto  
  inflating: include/google/protobuf/api.proto  
  inflating: include/google/protobuf/struct.proto  
  inflating: include/google/protobuf/descriptor.proto  
  inflating: include/google/protobuf/timestamp.proto  
   creating: include/google/protobuf/compiler/
  inflating: include/google/protobuf/compiler/plugin.proto  
  inflating: include/google/protobuf/empty.proto  
  inflating: include/google/protobuf/any.proto  
  inflating: include/google/protobuf/source_context.proto  
  inflating: include/google/protobuf/type.proto  
  inflating: include/google/protobuf/duration.proto  
   creating: bin/
  inflating: bin/protoc              
  inflating: readme.txt              
Protoc cached under /opt/hostedtoolcache/protoc/3.13.0/x64
Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
go env GOPATH
/home/runner/go
Warning: The `add-path` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
brendankenny commented

The message now states

Error: The `add-path` command is deprecated and will be disabled on November 16th

which is on Monday.

It looks like landing #12 should be all that's required to fix this (though actions/toolkit#630 has a few people still having issues).

kdorosh commented

@brendankenny landing that PR was the first step, but after testing (on our own fork) we found you'd also need to update the node modules.

The fix for this is in #17

kdorosh commented

This has been resolved

rsora commented

@g4s8 @kdorosh @brendankenny
Release v1.1.2 should fix the issue, can you please check it?

Thanks!

kdorosh commented

Works for us, we updated in solo-io/gloo#3876 . No GH deprecation warnings either.

  • 👍1
brendankenny commented

updating in GoogleChrome/lighthouse#11674, works there too. Thanks!

  • 👍1