argiopetech/base

Better filterSet handling

Closed this issue · 2 comments

argiopetech commented

Either:

  1. Automatically determine which filterSet a given photometry file is using based on the header, or
  2. Ensure that a at least one filter was loaded from the user-specified filterSet, or
  3. Check the size of the filter vector every time it is used. (Don't do this).

In addition, assert filters.size > 0 whenever we use filters.front() or filters.back()

Rationale

Loading a photometry file with the wrong filterSet results in a zero-length vector. This causes segfaults when we use .front() without checking size.

argiopetech commented

Went with option 2 for the moment. Will be adding option 1 as a new issue in the "| milestone.

tedvh commented

sure.

On 7/22/13 3:48 PM, Elliot Robinson wrote:

Went with option #2 #2 for the
moment. Will be adding option #1 #1
as a new issue in the /|/ milestone.

—
Reply to this email directly or view it on GitHub
#36 (comment).

Ted von Hippel

Department of Physical Sciences
Embry-Riddle Aeronautical University
600 S. Clyde Morris Boulevard
Daytona Beach, FL 32114-3900
386-226-7751