argoproj/applicationset

scmProvider should provide slug version of branch name

Closed this issue · 1 comments

because when you use {{branch}} in template.metadata.name and your branch happened to have slash, like feat/implement-a-new-feature you will get an error Invalid value: "feat/implement-a-new-feature": a lowercase RFC 1123 subdomain must consist of lower case alphanumeric characters, '-' or '.', and must start and end with an alphanumeric character (e.g. 'example.com', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?(\.[a-z0-9]([-a-z0-9]*[a-z0-9])?)*')

it would be cool to have slug version of branch which would be feat-implement-a-new-feature in this case

its {{branchNormalized}}