Merge Argo CD Image Updater into Argo CD
alexmt opened this issue · 16 comments
Summary
Merge Argo CD Image Updater into Argo CD
Motivation
The https://github.com/argoproj-labs/argocd-image-updater has been validated in production. One the v1.0 version is published it should be ready to get merged into Argo CD.
Proposal
Move https://github.com/argoproj-labs/argocd-image-updater into https://github.com/argoproj Github org and include installation manifests into default Argo CD bundle
I think for 2.3 only notifications and appset have been merged to argocd and this will be tracked in 2.4, right?
@m-yosefpor yes exactly, all informations are available on the ArgoCD roadmap
Currently the Image Updater is not compatible with ArgoCD Vault Plugin. Does anyone know if this is something that will be looked into during the merge?
Does anyone know if this is something that will be looked into during the merge?
During the merge, there most likely won't be any functional changes. But support for applications of other types than Helm and Kustomize (e.g. plugins, plain YAML apps) is definitely something we can look at once the code bases are merged.
Any updates on this topic? Is there any ETA on when the updater is going to be part of the ArgoCD core project?
Is there any update for it?
Merging image updater into argocd was on the roadmap of argocd for 2.5 and beyond long ago (used to be here https://github.com/argoproj/argo-cd/blob/master/docs/roadmap.md), the roadmap is no longer maintained in that file and is now managed in github projects here: https://github.com/orgs/argoproj/projects/25/views/14 (see #11137). According to the new roadmap, merging argocd image updater into argocd is not planned on any near future releases (v2.6, v2.7,v2.8), and have an In Design Status (You can contribute your ideas in design here #10447 and #11787). However the maintainers can give a more accurate answer.
No ETA yet. I've just added a task to my next sprint to review the proposal.
I came here via the Roadmap page in the documentation. Can we remove that if it is no longer maintained as @m-yosefpor says? I'll happily open a PR.
I came here via the Roadmap page in the documentation. Can we remove that if it is no longer maintained as @m-yosefpor says? I'll happily open a PR.
It is already handled via #11137 (merged 13 hours ago)
thats something id love to have :(
No ETA yet. I've just added a task to my next sprint to review the proposal.
Was there a review in the sprint or update?
Figured I would rather post here rather than pollute the PR.
I saw this PR comment this morning which states that Image Updater is going to be a first class citizen.
Can I take that to mean that Image Updater will be compatible with ApplicationSet Resources with the argocd write-back method?
I was looking forward to adopting ApplicationSets for our EKS Clusters, but I am unable because of this Issue which reveals that the argocd write back method is not supported:
Can I take that to mean that Image Updater will be compatible with ApplicationSet Resources with the argocd write-back method?
That's definitely the hope.
I was looking forward to adopting ApplicationSets for our EKS Clusters, but I am unable because of this Issue which reveals that the argocd write back method is not supported
If you have time to write some tests, this would probably solve your use case even before first-class image updater support: #14743
Cheers, I saw and am subscribed to that PR. :)
Might have a look soon as I'm getting back into go lately.
Thank you for the response