There is a $.select() question when i use display.es6.js

Question

Cslove opened this issue 7 years ago · 8 comments

i wanted to use $.s() function to select DOM node

but report errors: Uncaught RangeError: Maximum call stack size exceeded

so i checked your display.es6.js source code found that there is a question in "isElement()"function and "select()" function.

so i deleted the "el = this.s(el);" in "isElement()" function and it works!

Could you check the source code?

Answer 1 · 2017-09-15T11:35:58.000Z

Thank you a lot!!! I recommend you to do a Pull Request, so you can be in the contributors' list 😊

Answer 2 · 2017-09-15T11:39:43.000Z

You know what, I will fix it myself, and I will add you manually to the contributors' list

Answer 3 · 2017-09-15T12:46:01.000Z

ok，thank you. i am a young novice ,too.i will study your source code again!😊

Answer 4 · 2017-09-15T12:47:29.000Z

@Cslove No worries, I can understand, I'm 15 years old in fact 😊

Answer 5 · 2017-09-15T12:51:45.000Z

wow! incredible! you are my idol

Answer 6 · 2017-09-15T12:52:44.000Z

@Cslove Aha 😂

Answer 7 · 2017-09-15T12:54:15.000Z

By the way, I fixed the $.s(), and I released v2.0.1. Oh, and don't forget to leave a star on the project, it would be very cool

Answer 8 · 2017-09-15T12:57:27.000Z

yes，absolutely i have already stayed！