argumentcomputer/zk-light-clients

Remove magic value for nightly version

Closed this issue · 0 comments

We have nightly-2024-05-31 as a string in many places, which is not good development practice, will need to be upgraded (writing this as of 08-13 nightly for sphinx), and will be a pain to upgrade (including in docs):

huitseeker@binky➜~/tmp/zk-light-clients(adapt-forward_ports_43)» rg nightly-2024-05-31
ethereum/light-client/Makefile
8:      cargo +nightly-2024-05-31 bench --bench $$bench
16:     cargo +nightly-2024-05-31 bench --bench $(BENCH)

ethereum/docs/src/run/setup_proof_server.md
27:Make sure to launch the proof servers with `cargo +nightly-2024-05-31`.
41:  SHARD_SIZE=4194304 SHARD_BATCH_SIZE=0 RUSTFLAGS="-C target-cpu=native -C opt-level=3" cargo +nightly-2024-05-31 run --release --bin server_secondary -- -a <NETWORK_ADDRESS>
51:  SHARD_SIZE=4194304 SHARD_BATCH_SIZE=0 RUSTFLAGS="-C target-cpu=native -C opt-level=3" cargo +nightly-2024-05-31 run --release --bin server_primary -- -a <NETWORK_ADDESS> --snd-addr <SECONDARY_SERVER_ADDRESS>

ethereum/docs/src/run/configuration.md
11:rustup default nightly-2024-05-31

ethereum/docs/src/benchmark/on_chain.md
99:RUST_LOG=info RUSTFLAGS="-C target-cpu=native --cfg tokio_unstable -C opt-level=3" SHARD_SIZE=4194304 SHARD_BATCH_SIZE=0 cargo +nightly-2024-05-31 run --release --bin generate-fixture -- --program inclusion --language move

aptos/proof-server/benches/proof_server.rs
116:            "+nightly-2024-05-31",
166:            "+nightly-2024-05-31",

ethereum/docs/src/benchmark/proof.md
91:SHARD_BATCH_SIZE=0 cargo +nightly-2024-05-31 bench --bench execute -- <benchmark_name>
151:SHARD_BATCH_SIZE=0 cargo +nightly-2024-05-31 nextest run --verbose --release --profile ci --package ethereum-lc --no-capture --all-features

ethereum/docs/src/benchmark/configuration.md
33:- `cargo +nightly-2024-05-31`

aptos/docs/src/run/setup_proof_server.md
29:Make sure to launch the proof servers with `cargo +nightly-2024-05-31`.
43:  SHARD_BATCH_SIZE=0 RUSTFLAGS="-C target-cpu=native --cfg tokio_unstable -C opt-level=3" cargo +nightly-2024-05-31 run --release --bin server_secondary -- -a <NETWORK_ADDRESS>
53:  SHARD_BATCH_SIZE=0 RUSTFLAGS="-C target-cpu=native --cfg tokio_unstable -C opt-level=3" cargo +nightly-2024-05-31 run --release --bin server_primary -- -a <NETWORK_ADDESS> --snd-addr <SECONDARY_SERVER_ADDRESS>

ethereum/docs/src/run/setup_client.md
20:  MODE=SNARK RUST_LOG="debug" cargo +nightly-2024-05-31 run -p light-client --release --bin client -- -c <CHECKPOINT_PROVIDER_ADDRESS> -b <BEACON_NODE_ADDRESS> -p <PROOF_SERVER_ADDRESS> -r <RPC_PROVIDER_ADDRESS>

aptos/docs/src/run/configuration.md
11:rustup default nightly-2024-05-31

aptos/docs/src/benchmark/on_chain.md
72:RUST_LOG=info RUSTFLAGS="-C target-cpu=native --cfg tokio_unstable -C opt-level=3" SHARD_SIZE=4194304 SHARD_BATCH_SIZE=0 cargo +nightly-2024-05-31 run --release --bin generate-fixture -- --program inclusion --language solidity

aptos/docs/src/run/setup_client.md
17:  RUST_LOG="debug" cargo +nightly-2024-05-31 run -p proof-server --release --bin client -- --proof-server-address <PRIMARY_SERVER_ADDRESS> --aptos-node-url <APTOS_NODE_URL>

aptos/docs/src/benchmark/configuration.md
33:- `cargo +nightly-2024-05-31`

aptos/docs/src/benchmark/e2e.md
13:SHARD_BATCH_SIZE=0 RUSTFLAGS="-C target-cpu=native --cfg tokio_unstable -C opt-level=3" PRIMARY_ADDR="127.0.0.1:8080" SECONDARY_ADDR="127.0.0.1:8081" cargo +nightly-2024-05-31 bench --bench proof_server
57:SNARK=1 SHARD_BATCH_SIZE=0 RUSTFLAGS="-C target-cpu=native --cfg tokio_unstable -C opt-level=3" PRIMARY_ADDR="127.0.0.1:8080" SECONDARY_ADDR="127.0.0.1:8081" cargo +nightly-2024-05-31 bench --bench proof_server

aptos/docs/src/benchmark/proof.md
74:SHARD_BATCH_SIZE=0 cargo +nightly-2024-05-31 bench --features aptos --bench execute -- <benchmark_name>
140:SHARD_BATCH_SIZE=0 cargo +nightly-2024-05-31 nextest run --verbose --release --profile ci --features aptos --package aptos-lc --no-capture

aptos/light-client/Makefile
8:      cargo +nightly-2024-05-31 bench --features aptos --bench $$bench
16:     cargo +nightly-2024-05-31 bench --features aptos --bench $(BENCH)

aptos/core/README.md
25:SHARD_BATCH_SIZE=0 cargo +nightly-2024-05-31 nextest run --verbose --release --profile ci --features aptos --package aptos-lc --no-capture

Let's make sure we define this variable in a single place.