ariary/QueenSono

Optimize packet size

Opened this issue · 2 comments

ariary commented

It seems that the getPacket does not take into account ICMP packet header:
cf

QueenSono/pkg/icmp/receive.go

Line 138 in 59dd5da

func getPacket(c *icmp.PacketConn, data []string, indexes map[int]int) {

Try replace it by 65535, to get the whole size of th ip packet

(https://stackoverflow.com/questions/9449837/maximum-legal-size-of-icmp-echo-packet)

ariary commented

Change default value to 65505, don't know why work a bit but
sendto: message too long after a bit

ariary commented

It seems that the ICMP headers don"t have fixed length and could be > 28 bytes.
idem for data.
Don't know if it is depending on the OS or the net/icmp library

=> Change default value of data packet size to 65488 (Data take 2bytes more afterwards, and sometimes 3)

If you want to avoid any crash use -s 65450