arichiardi/replumb

Example from README doesn't seem to be working

Closed this issue · 6 comments

nbeloglazov commented

Hi

I'm trying to run example from README. But it doesn't compile because replumb.browser.io is not present in the library. I checked source of replumb-0.1.4.jar and it is indeed not there. Looking at project.clj it seems like src/browser folder is used as source only in dev mode (locally) but not gets included into packaged library. Could you take a look?

Thanks,
Nikita

arichiardi commented

It is unfortunately not possible to include io parts in the same package without breaking. There are two (or more) io target and they are exclusive (browser, node). If I had included one, the other would have not be compiled correctly.

The only solution to this are reader conditionals. But custom reader conditionals did not yet land in neither Cuojure nor ClojureScript. A custom reader conditional tagged nodejs would solve.

In the meantime, feel free to copy over those namespaces, following along checking the repl-demo folder.

nbeloglazov commented

I see. Should example/instructions in README be also fixed? Right now README states that includeing replumb as dependency is sufficient to run example which is not entirely true.

arichiardi commented

I will better specify (hopefully) that, thanks a lot!

nbeloglazov commented

Thanks!

arichiardi commented

Thank you for pointing it out!