Adding support for r8b -here is the code

Question

Adding support for r8b -here is the code

Closed this issue 9 years ago · 5 comments

GoogleCodeExporter commented 9 years ago


edit android.toolchain.cmake

change line 202
set( ANDROID_SUPPORTED_NDK_VERSIONS ${ANDROID_EXTRA_NDK_VERSIONS} -r8 -r7c -r7b 
-r7 -r6b -r6 -r5c -r5b -r5 "" )
to
set( ANDROID_SUPPORTED_NDK_VERSIONS ${ANDROID_EXTRA_NDK_VERSIONS} -r8b -r8 -r7c 
-r7b -r7 -r6b -r6 -r5c -r5b -r5 "" )

change line 476 from
string( REGEX MATCH "[0-9]+.[0-9]+.[0-9]+$" __version "${__toolchain}" )
to
string( REGEX MATCH "([0-9.]+)+$" __version "${__toolchain}" )

reason the new 4.6 toolchain is not named 4.6.0 in r8b

can someone push this chane to the code base please?
Kind Regards
Martell Malone

Original issue reported on code.google.com by MartellM...@gmail.com on 23 Jul 2012 at 1:12

Answer 1 · 2015-08-13T14:44:48.000Z

[deleted comment]

Answer 2 · 2015-08-13T14:44:48.000Z

[deleted comment]

Answer 3 · 2015-08-13T14:44:48.000Z

eh, I made a patch for r8b

https://github.com/ifreedom/libnge2/commit/4858723ad90a473620ac4eaa3022394a54cbf
260

Original comment by ifreedom...@gmail.com on 27 Jul 2012 at 1:01

Answer 4 · 2015-08-13T14:44:48.000Z

That looks a lot cleaner.
Thanks dude

Original comment by MartellM...@gmail.com on 27 Jul 2012 at 12:21

Answer 5 · 2015-08-13T14:44:49.000Z

r8b support is added. No one of suggested patches is not applied because of 
incompleteness.

Original comment by andrey.k...@itseez.com on 19 Aug 2012 at 5:11

Changed state: Fixed