Suggestion isShowing misleading name
Opened this issue · 1 comments
AndreHaueisen commented
Hi. First of all, I love Flashbar. You did a great job there.
I would like to make one suggestion. I think Flashbar.isShowing() is a bit misleading. You use it as an opposition to Flashbar.isDismissing().
Consider using the name Flashbar.isAppearing() or Flashbar.isEmerging() instead. It represents its functionality in a better way.
Flashbar.isShowing() should substitute Flashbar.isShown() in my opinion.
Hope you take it into consideration.
Cheers.
aritraroy commented
Thanks for the suggestion. Flashbar.isAppearing()
seems like a good name to go with. We can add it in the coming update.