Review the use of escope

Question

Review the use of escope

ariya opened this issue 12 years ago · 7 comments

ariya commented 12 years ago

Since I'm not too familiar with escope API, the way esrefactor is using it might be not optimal.

Answer 1 · 2013-04-08T06:38:05.000Z

@Constellation If you would like to help/review, it will be appreciated! Thank you.

Answer 2 · 2013-04-08T18:01:50.000Z

Thanks. OK, I'll review this.

Answer 3 · 2013-04-08T19:42:10.000Z

Reference has resolved property, by using this, we can access to variable definition easily.

But sometimes, resolved property may become null, this is because escope is very presice and pessimistic analyzer.

For example,

(function () {
    var i = 20;
    eval(str);
    function test() {
        i;  // this
    }
}());

This i reference doesn't have resolved property because direct call to eval taints upper scope.

Answer 4 · 2013-04-08T19:43:59.000Z

I'll add more user friendly API to escope and documentation, so If you have requests, please file issue :)

Answer 5 · 2013-04-10T04:39:21.000Z

@Constellation Is your clean-up ready? Should I merge it or should I wait for more commits?

Answer 6 · 2013-04-16T05:37:16.000Z

Closed, thanks to @Constellation!

Answer 7 · 2013-04-16T05:47:03.000Z

Sorry for my very late reply. This is because I'm now working on my research hardly...
Later I'll update escope with more friendly API and create issue again.

Thanks @ariya :)