withDistances doesn't respect `units` parameter

Question

withDistances doesn't respect `units` parameter

Closed this issue 9 years ago · 7 comments

Hey! I noticed that when doing a query like:

geo.nearby(location, 0.5, { withDistances: true, units: 'mi' }, function(err, locations) {
    // locations contain a distance key, but the distance is in meters
})

Not a big deal (I can do the conversion on my side), but I figured it might be nice to have the units be consistent if it's an easy change.

Answer 1 · 2015-10-06T00:39:08.000Z

Hey there @jesseditson

Thanks so much for reporting this.
Can you confirm a few things?

Are you using the nativeGeo mode? (ie. do you have redis 3.1.199 or higher?)
If not, were you using the accurate option? I found a bug in the code where I forgot to convert units, but only when using the accurate option in emulated mode.

Answer 2 · 2015-10-06T00:44:51.000Z

Hey! I'm using accurate, and I'm not using native yet - currently on v2.8.19, so it sounds like I'm experiencing the exact bug you mentioned!

Answer 3 · 2015-10-06T00:49:53.000Z

Oh perfect. I'll fix and publish in a sec.

Answer 4 · 2015-10-06T00:59:49.000Z

Published! Give it a try.

Answer 5 · 2015-10-06T01:00:47.000Z

Awesome! I'll bump my version and test it out!

Answer 6 · 2015-10-06T01:05:24.000Z

This looks good on my end! Seems to be fixed by 2a564c3. Thanks a bunch!

Answer 7 · 2015-10-06T01:18:51.000Z

Awesome. Thanks for reporting the bug!