arlyon/async-stripe

Pinning `time-core` causes dependency conflicts

tecc opened this issue · 3 comments

tecc commented

Describe the bug

Adding async-stripe as a dependency creates a conflict because async-stripe has locked time-core to <=0.1.0, whereas the version of time my project depends on uses 0.1.1.

To Reproduce

  1. Use time-core version 0.1.1 (or time version 0.3.21 or later).
  2. Use async-stripe version 0.22.1 or later.

Expected behavior

It works?

Code snippets

# Cargo.toml
[dependencies]
async-stripe = { version = "0.22.2", features = ["runtime-tokio-hyper-rustls"] }
time = { version = "0.3.22" }

OS

Ubuntu

Rust version

1.70.0 (90c541806 2023-05-31)

Library version

async-stripe 0.22.2

API version

None - I haven't even begun using the API yet.

Additional context

No response

ahartel commented

We also ran into this by using vergen v8.2.4 which requires time-core 0.1.1 transitively.

arlyon commented

Thanks for the response. I am going to look into removing this requirement, please hold on. Edit: the PR in question is good, bar one minor change.

  • 🚀1
timsueberkrueb commented

I think this issue can be closed now.

  • 👍1