arnaudmiribel/streamlit-extras

Context Manager support for GridDeltaGenerator

Opened this issue · 2 comments

Description

Hi,
Its has been more than a year since Row, GridDeltaGenerator has been added but there has been no light on adding context manager support about them.
The original PR author had written and commented them down saying "doesn't work", if you could look into the matter it will save us a lot of times and less problematic codes.

https://github.com/arnaudmiribel/streamlit-extras/blob/main/src/streamlit_extras/grid/__init__.py#L51

Hi @KingMahmud,

Its has been more than a year since Row, GridDeltaGenerator has been added but there has been no light on adding context manager support about them.

Thanks for following up. Right, context manager support for Row and GridDeltaGenerator would be great. I admit I've missed them a couple of times too. If you’re interested, contributions are always welcome—it’s OSS, after all! Appreciate your patience and interest!

if you could look into the matter it will save us a lot of times and less problematic codes.

Btw can you tell more about the limitations you encounter without context manager?

cc-ing @lukasmasuch who's the author, if they happen to have a quick suggestion for this

I remember that adding a context manager was a bit tricky based on the way it's currently built. Also, we are planning to ship new native layout commmands in Streamlit soon (probably the beginning of next year). And these will definitely also work via context manager.