arnav1776/Hogwarts

Styling end.html file

Closed this issue · 9 comments

Hi Arnav1776 , I would like to contribute in this project by styling end.html file and I would love to make some documentation on how to use end.html page which could be added in your readme for ease of user's and if there anything else you want to add in end.html , I would like to know it . Also add HacktoberFest label on this issue . Thank You .

There is already someone working on end.html you can work on the documentation part.

I also created a pull request can you check it once .

@Rahulkumar2002 You have done good work but there was already an open pr for that #17 so I can't merge your pr I'd be happy to assign you any other issues if you have any ideas.

In index.html there is a line Draco-Dormiens-Nunquam-Titillandus , instead of this line why don't we put some random intresting facts about Howgwart and Harry Potter in it which will be changing every 24 hours . I can try to do this using Js. What do you say ?

IMG_20211007_154054

Don't remove that line instead add you feature between these two sections, also create a new pr for any new change that you want to add.

ok should i create a issue or u will do it or do i directly make change do a pr?

You don't need to create new issues for these just create different PRs say if you want to add to documentation create a separate
PR for that & a separate PR for the facts feature and in future if you want to add anything then first create a new issue for that then you can work on it when it is assigned to you.

You don't need to create new issues for these just create different PRs say if you want to add to documentation create a separate
PR for that & a separate PR for the facts feature and in future if you want to add anything then first create a new issue for that then you can work on it when it is assigned to you.

Ok