arnowelzel/photoswipe-fullscreen

UMD distribution needed

Opened this issue · 3 comments

ajssd commented

The PhotoSwipe 5 distribution includes support for non-ESM (that is, UMD) uses here.

Is it possible for this add-on to also include a UMD build, for those of us that cannot (yet) move to ESM?

arnowelzel commented

Sorry, at the moment I just don't have the time to support an additional UMD version based on the ESM version.

Can you be a bit more specific about "cannot (yet) move to ESM"? ESM is more or less supported by all current browsers according to https://caniuse.com/?search=ESM. Only IE and Opera Mini don't support that. What is the usecase of the UMD version here?

ajssd commented

Thanks for the quick reply. I know all browsers support ESM; the issue is that we have a very large product based on RequireJS and similar (older) technology, with complex build process, etc. We'll get there eventually. For now, I'll just write some custom code to support full-screen mode, using the hints I see here.

arnowelzel commented

Any assistance in creating a UMD version is welcome. I just can't do it for the time being due to the lack of time.