arrayfire/arrayfire-haskell

Remove unimplemented internal functions.

noughtmare opened this issue · 4 comments

noughtmare commented

Running cabal test fails because the linker can't find these functions:

In Image.hsc:

  • af_iterative_deconv
  • af_iverse_deconv

In LAPACK.hsc:

  • af_pinverse

In Signal.hsc:

  • af_approx1_uniform
  • af_approx2_uniform

Should these functions be removed?

dmjio commented

@noughtmare can you confirm you're using 3.6.4. If so, then yes I can make a PR to comment them out. They might have been implemented from building off of master.

noughtmare commented

@dmjio Yes, I'm using 3.6.4. Interestingly, there are some comments in the higher level *.hs files about this:

arrayfire-haskell/src/ArrayFire/LAPACK.hs

Line 198 in 65bdf72

-- Not implemented in /3.6.4/
and

arrayfire-haskell/src/ArrayFire/Signal.hs

Line 561 in 65bdf72

-- DMJ: did this get removed? Can't find in latest docs

dmjio commented

fftConvolve1 was commented out. I'll update the others as well. Thanks for looking into this.