arriqaaq/flashdb

Not using value parameter

gozeloglu opened this issue · 3 comments

gozeloglu commented

Hi,

I've seen that value is not being used in here. Is there any reason to not use the value parameter? If you miss to use it, I can fix it.

arriqaaq commented

Thank you for the comment @gozeloglu

The SetEx method is currently implemented on the key. The idea is that as follows

set foo bar #for setting value
setex foo 15. #for setting expiry

We could definitely combine this into a single command, what do you think?

gozeloglu commented

The SetEx method is currently implemented on the key.

What do you mean by this? Where is the key?

We could definitely combine this into a single command, what do you think?

Do you mean by combining Set and SetEx with a single command? If yes, I think it's not a good idea, because the commands' purposes are different.

arriqaaq commented

What do you mean by this? Where is the key?

The SetEx method would only use key in the params in the function

We could definitely combine this into a single command, what do you think?
Redis already has a setex command which does the same

https://redis.io/commands/setex/