arrowtype/shantell-sans

Subfamily name discrepancy

Closed this issue · 6 comments

yanone commented

I checked the 1.006 fonts designated for Google Fonts again, and found this last issue remaining:

     FAIL 'Light' instance has the same coordinates as the                      
          default instance; its subfamily name should be 'Regular' [code:       
          invalid-default-instance-subfamily-nameid:344]

The message suggests to set name ID 17 to Regular and Italic.

However, I want to point out the following discrepancy: The axis section of the DesignSpace files in the sources folder show weight 300 to be the default, while add-STAT.py in the helpers folder shows the Regular (400) to be the default.

My guess is that either one is correct, not both, and that FAIL disappears as soon as this is aligned to either one. But then again the build setup is very complicated and I'm not sure which files are even involved.

Please take another look at this.

arrowtype commented

Can I ask what version of fontbakery you ran this check with? I think this may be resolved in the latest version, via fonttools/fontbakery#3896

arrowtype commented

If I run pip install -U fontbakery and then the check-googlefonts checks, I no longer get this fail.

yanone commented

I just ran it again after updating fontbakery. Still there. Just making sure: I ran this on the fonts in fonts/shantell_sans-for-googlefonts

arrowtype commented

Actually, their last official release was 22 days ago.

What if you update with:

pip install git+https://github.com/googlefonts/fontbakery

Yes, that is the correct directory for the fonts I intend to PR.

yanone commented

Yup, it disappeared 👍

arrowtype commented

Awesome, thanks for letting me know!