arshadkazmi42/currency-symbols

Can't easily import this module

snoopyjc opened this issue · 7 comments

snoopyjc commented

This module has a '-' in it's name, so the only way to import it is to:

import importlib
currency_symbols = importlib.import_module('currency-symbols')
arshadkazmi42 commented

Is it. I never thought this is a problem in python import.
We should get this fixed. Would you like to take a try on this?

loricvdt commented

I'm also having issues importing it. I just replaced the dash in the directory name of the module by an underscore and changed imports to relative to fix it. I'm making a pull request to fix it (hopefully), it should then be updated on pip

ilya1200 commented

Also having troubles with importing.
Would be great to have that fixed.

loricvdt commented

@ilya1200 my PR should solve the issue, you can try it out and see if it does the trick

arshadkazmi42 commented

This is deployed v2.0.0 @loricvdt @ilya1200 can you try this now.

loricvdt commented

Works great thanks!
(tested on Windows Python 3.9.0 and Ubuntu Python 3.6.9)

arshadkazmi42 commented

Awesome.
Closing this issue.