🔒 Fix LibString
transmissions11 opened this issue · 7 comments
I think the ERC721A and Solady also has the same issue. I've talked to @Vectorized about it. They are aware of it now. But as far as we can tell, it doesn't really affect their on chain contracts.
@hrkrshnn could use a final review if you have a sec :)
https://github.com/artgobblers/art-gobblers/blob/master/src/utils/lib/LibString.sol
I had a look at it today and it looks good. I'll try to write some tests tomorrow and check again.
oh no sorry to send you on a bit of a goose chase, ended up cleaning up solady's, putting it in solmate, and using that in this PR instead of the one on master:
no pressure to review if its too much of a burden, we rly appreciate all your work here already
You mean https://github.com/transmissions11/solmate/blob/main/src/utils/LibString.sol right?
Looks pretty much the same as the one I reviewed. Also, the tests look good transmissions11/solmate@1c48742
yup. thanks for taking a look. 🙏