Galleries A-Z page not fetching all the partners
starsirius opened this issue · 4 comments
Reported again: https://artsy.slack.com/archives/C03JWJLLH/p1508165922000035
Looking into this some more…
- There are now >2000 partners eligible for this list
- But we top out at 2000, because we ask for 20 results per page, and we are limited to 100 pages
- The 100-page limit is imposed by the partners endpoint; requests for the 101st page will always fail
- I'm not sure why have that 100-limit (maybe @mzikherman remembers), but I do note that the endpoint goes through Elasticsearch, which discourages deep paging
The simplest short-term solution would be to simply bump the page-size, to say 40. That doesn't solve the problem but it would postpone it while we figure out a better solution to this issue (or reconsider the value of an A-Z page which has grown so large)
Seems like lifting the cap postponed the problem for some time, but now we're back up against the wall with some newly-joined partners not showing up in the list again.
@roop and @starsirius, do you have a sense of whether this is something that could be completed in a half day during bug-bash time, or is it a bigger issue entirely?
Pinging the right roop: @anandaroop