Version 0.2.5 fails to detect libwebp 1.3.2
Closed this issue · 6 comments
darkshram commented
libwebp-devel 1.3.2 is installed, but meson fails to find it. Works perfectly with version 0.2.4.
+ umask 022
+ cd /builddir/build/BUILD
+ cd /builddir/build/BUILD
+ rm -rf webp-pixbuf-loader-0.2.5
+ /usr/bin/gzip -dc /builddir/build/SOURCES/webp-pixbuf-loader-0.2.5.tar.gz
+ /bin/tar -xf -
+ STATUS=0
+ '[' 0 -ne 0 ']'
+ cd webp-pixbuf-loader-0.2.5
+ /bin/chmod -Rf a+rX,u+w,g-w,o-w .
+ exit 0
Ejecutando(%build): /bin/sh -e /var/tmp/rpm-tmp.edbCDJ
+ umask 022
+ cd /builddir/build/BUILD
+ cd webp-pixbuf-loader-0.2.5
+ CFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables'
+ export CFLAGS
+ CXXFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables'
+ export CXXFLAGS
+ FFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -I/usr/lib/gfortran/modules'
+ export FFLAGS
+ FCFLAGS='-O2 -g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector-strong --param=ssp-buffer-size=4 -grecord-gcc-switches -m32 -march=i686 -mtune=atom -fasynchronous-unwind-tables -I/usr/lib/gfortran/modules'
+ export FCFLAGS
+ LDFLAGS='-Wl,-z,relro '
+ export LDFLAGS
+ /usr/bin/meson --buildtype=plain --prefix=/usr --libdir=/usr/lib --libexecdir=/usr/libexec --bindir=/usr/bin --sbindir=/usr/sbin --includedir=/usr/include --datadir=/usr/share --mandir=/usr/share/man --infodir=/usr/share/info --localedir=/usr/share/locale --sysconfdir=/etc --localstatedir=/var --sharedstatedir=/var/lib --wrap-mode=nodownload --auto-features=enabled . i686-redhat-linux-gnu -D gdk_pixbuf_query_loaders_path=gdk-pixbuf-query-loaders-32 -D update_cache=false
The Meson build system
Version: 0.64.1
Source dir: /builddir/build/BUILD/webp-pixbuf-loader-0.2.5
Build dir: /builddir/build/BUILD/webp-pixbuf-loader-0.2.5/i686-redhat-linux-gnu
Build type: native build
Project name: webp-pixbuf-loader
Project version: undefined
C compiler for the host machine: ccache cc (gcc 8.5.0 "cc (GCC) 8.5.0 20210514 (Red Hat 8.5.0-4)")
C linker for the host machine: cc ld.bfd 2.30-119
Host machine cpu family: x86
Host machine cpu: i686
Found pkg-config: /usr/bin/pkg-config (0.29.1)
Run-time dependency gio-2.0 found: YES 2.72.4
Run-time dependency gdk-pixbuf-2.0 found: YES 2.42.10
Dependency libwebp found: NO found 1.3.2 but need: '>1.3.2'
Found CMake: /usr/bin/cmake (3.26.5)
Run-time dependency libwebp found: NO (tried cmake)
meson.build:10:0: ERROR: Dependency lookup for libwebp with method 'pkgconfig' failed: Invalid version, need 'libwebp' ['>1.3.2'] found '1.3.2'.
A full log can be found at /builddir/build/BUILD/webp-pixbuf-loader-0.2.5/i686-redhat-linux-gnu/meson-logs/meson-log.txt
darkshram commented
The fix for this is:
diff -Naur webp-pixbuf-loader-0.2.5.orig/meson.build webp-pixbuf-loader-0.2.5/meson.build
--- webp-pixbuf-loader-0.2.5.orig/meson.build 2023-09-22 08:17:10.000000000 -0600
+++ webp-pixbuf-loader-0.2.5/meson.build 2024-01-23 21:13:33.323305331 -0600
@@ -7,9 +7,9 @@
gdk_pb_moddir = gdkpb.get_variable(pkgconfig: 'gdk_pixbuf_moduledir', pkgconfig_define: ['prefix', get_option('prefix')])
endif
-webp = dependency('libwebp', version: '>1.3.2')
-webpdemux = dependency('libwebpdemux', version: '>1.3.2')
-webpmux = dependency('libwebpmux', version: '>1.3.2')
+webp = dependency('libwebp', version: '>=1.3.2')
+webpdemux = dependency('libwebpdemux', version: '>=1.3.2')
+webpmux = dependency('libwebpmux', version: '>=1.3.2')
pbl_webp = shared_module('pixbufloader-webp',
sources: ['io-webp.c', 'io-webp-anim.c', 'io-webp-anim-iter.c'],
rahulc07 commented
Can confirm, seems like it was already resolved in this commit 834657c but for some reason that didn't make it into this release
kloczek commented
Looks like it would be good to make new release 🤔
aruiz commented
My bad, I will make a new release, lemme fix this f-up.
aruiz commented
Fixed!
kloczek commented
Thank you 👍