Remove dynamic captions of checkboxes in settings dialog
srcds opened this issue · 3 comments
In the settings dialog there are several binary options which are controlled via ticking or unticking checkboxes. The caption right to the checkbox changes between “Yes”/”No” depending on whether the option is selected or not. I find this highly confusing.
I wanted to configure a project in such a way that all attributes of suppressed records were removed. Looking at the Transformation tab, I thought this behavior was already configured:
In my mind, the default for the second and third option was “Yes” and the non-default “No” must be selected manually by ticking it. As the anonymization was not removing all attributes, I revisited the options dialog and realized that the captions of the checkboxes change depending on whether they are ticked:
The problem: a “Unticked No” can be interpreted the same way as a “Ticked Yes”. I would strongly suggest changing the caption of the checkboxes to a static “Yes” or remove the caption completely. This change is easy to implement and I can't think of any disadvantages.
Captions are removed. I will create a pull request for this soon when the solution is approved.
Some details:
The code for this part can be found in createTabTransformation function. This function uses import de.linearbits.preferences.PreferencesDialog; which is part of swtpreferences library. The source code for this library is not provided in arx, it is provided here.
Fix commit