asafdav/ng-s3upload

compile method - bucket fix?

Closed this issue · 3 comments

I made this change to get the bucket so it would get set:

var bucket = (scope.$eval(attrs.bucket)) ? scope.$eval(attrs.bucket) : attrs.bucket;

which is ~line# 177 in build/ng-s3upload.js.

var bucket = scope.$eval(attrs.bucket);

The above was coming up with bucket as being undefined.

This is in the compile method belonging to the ngS3upload directive.

If you don't want to have bucket evaluated in your scope (probably because it isn't defined) you could just pass a string with the attribute.

<div s3-upload bucket="'the-name-of-my-bucket'">

Roger that and thanks!

Sorry for my lack of response, things are hectic here lately.
@GWStuartClift Thanks for your help!