asappresearch/flambe

Make `extra_validation_metrics` a key-value mapping rather than a list

Closed this issue · 1 comments

Is your feature request related to a problem? Please describe.
Each metric in extra_validation_metrics (provided to the default Trainer) must be of a different classes, because each is written to Tensorboard using its class name. This prohibits logging different metrics of the same class with different configurations, because they'll be overwritten.

Describe the solution you'd like
Make extra_validation_metrics a key-value mapping rather than a list.

Describe alternatives you've considered
This could be handled by a custom Trainer, or each metric with different parameter could be implemented as a separate class.

Additional context

resolved by #198