Check source for application module in `Igniter.Application.add_new_child/2`

[zachdaniel]

At the moment, we check the existing application, but this could be out of date due to some existing patch.

Here is where we check it:

    to_perform =
      case project.application()[:mod] do
        nil -> {:create_an_app, Igniter.Code.Module.module_name("Application")}
        {mod, _} -> {:modify, mod}
        mod -> {:modify, mod}
      end

This should pull from the source.

[sigu]

Does this mean, we should be able to check if our Mix.Project defines a custom application on the mix file by reading the mix file directly?

[zachdaniel]

Yes, exactly.

[zachdaniel]

The source code must always be the source of truth, whereas this is using the compiled code which will cause bugs down the line.

[sigu]

Can I pick this up @zachdaniel ?
I am currently thinking of using the AST from rewrite to check if inside our application function the config for mod is defined then return it otherwise return nil. I have no idea how to do this or if it is a good idea to in the first place.

What do you think?

[zachdaniel]

Yes please, that would be excellent 🙇

[zachdaniel]

I've assigned it to you. Take a look at some of the other functions in igniter to see how to traverse source code, and LMK if you hit any roadblocks.

[sigu]

Awesome, are there any hard timelines on this?

[zachdaniel]

Nope :) but ideally in the next few weeks it would be done 👍