Maintaining, docs etc
Closed this issue · 3 comments
ivantsov commented
Hi @ashaffer. Recently I discovered your package because I need to watch for changes in a piece of Redux store. I've started investigating the package and realized that have the following questions:
- Are you going to maintain the package?
- Are you going to amend docs and add better example(s)?
- What's the reason of using
path
andkey
forsubscribe
function?
Thanks in advance :)
ashaffer commented
- Kinda. I don't really have any particular plans to do anything with it at the moment. I'd be happy to give you access if you wanted to make improvements though.
- I should, i'm not sure when i'll get around to it exactly.
- So
path
is the path in your redux state atom that you want to listen to.key
is a unique token used as a handle to the subscription so that you can remove it later.
ivantsov commented
Thanks for answering @ashaffer.
So, I can take care of the package and here are the things that I'd like to change:
- get rid off
key
parameter andunsubscribe
method. It's easier to use closure and returnunsubscribe
function fromsubscribe
one (the same way works Reduxstore.subscribe
) - use Jest instead of Tape
- use Airbnb styleguide instead of standard one
If you're don't mind about all these changes and a few others - I can lead the project.
ivantsov commented
So, if anybody is interested I've created my own package - https://github.com/ivantsov/redux-subscriber.
Anyway, thanks for your work on this project!