askvortsov1/flarum-rich-text

Missing tooltip translation

imorland opened this issue · 1 comments

imorland commented

image

Looking at https://github.com/flarum/core/blob/11b1ab593226a2412913892d7c7850e0e379dcc1/locale/core.yml#L286

This key should be core.forum.composer.preview_tooltip?

rob006 commented

This key should be core.forum.composer.preview_tooltip?

This translation should not be used directly in the first place. AFAIK every context should use unique key.

flarum-rich-text/js/src/common/applyEditor.js

Line 27 in 7fe9acf

<Tooltip text={app.translator.trans('core.lib.composer.preview_tooltip')}>

Also I'm not sure what is the BC policy for translations in Flarum core. Could Flarum remove some unused keys in minor/patch release? That could break extensions that use these keys.