[Deployment] Add ability to RegisterSchema

Question

[Deployment] Add ability to RegisterSchema

aslotte opened this issue 4 years ago · 5 comments

Is your feature request related to a problem? Please describe.
We currently have a SchemaGenerator but no way to store it.

Describe the solution you'd like
At the time at which someone would like to deploy a model to a container, they most likely don't have access to the input and output types. We need to store the types in a new table associated with the run.

I'm thinking a table called ModelSchema with columns:

ModelSchemaId
RunId
Name (string, either ModelInput or ModelOutput)
Schema (string)

I'm thinking a method called RegisterSchema<TInput, TOutput>(Guid runId)

Answer 1 · 2020-09-24T21:08:26.000Z

@AnoojNair if you're looking for a new issue, this would be a good one. I'm happy to pick it up otherwise.

Answer 2 · 2020-09-26T06:27:04.000Z

@aslotte Thanks, I will assign this to myself..

Answer 3 · 2020-09-27T09:08:43.000Z

@aslotte , do we need to pass in the name of the input and output class as parameters too for the register schema method as the schema generator expects a class name to be passed in.

Answer 4 · 2020-09-27T13:07:14.000Z

No need for the user to pass that in, as they need to be the same every time (ModelInput and ModelOutput) for the dotnet new project template to compile. We'll just pass that in separately when using the SchemaGenerator

Answer 5 · 2020-10-02T00:05:55.000Z

@AnoojNair just checking in if you need any help with this issue. I think it may be the final one for v1.2 apart from stability testing and potentially some smaller tweaks :)