Versions are off
Closed this issue · 3 comments
IngwiePhoenix commented
I was experiencing weird behavior, as explained in Gitter. So I decided to whipe my node_modules and re-install.
Surprisingly, this came out:
/Users/Ingwie/Work
├─┬ phpruntime@2.4.0
│ ├── bluebird@2.10.2
│ ├── lodash@3.10.1
│ ├─┬ pausable@2.0.6
│ │ ├── acorn@2.6.4
│ │ ├─┬ escodegen@1.7.1
│ │ │ ├── esprima@1.2.5
│ │ │ ├── estraverse@1.9.3
│ │ │ ├── esutils@2.0.2
│ │ │ ├─┬ optionator@0.5.0
│ │ │ │ ├── deep-is@0.1.3
│ │ │ │ ├── fast-levenshtein@1.0.7
│ │ │ │ ├── levn@0.2.5
│ │ │ │ ├── prelude-ls@1.1.2
│ │ │ │ ├── type-check@0.3.2
│ │ │ │ └── wordwrap@0.0.3
│ │ │ └─┬ source-map@0.2.0
│ │ │ └── amdefine@1.0.0
│ │ └── estraverse@4.1.1
│ ├── phpcommon@1.2.1
│ ├── phptoast@2.1.1
│ └── phptojs@1.3.1
├─┬ phptoast@3.10.0
│ ├── parsing@1.1.0
│ └── phpcommon@1.3.0
└─┬ phptojs@3.8.0
├── microdash@1.3.0
├─┬ phpcommon@1.3.0
│ └── template-string@1.1.0
└── transpiler@1.2.0
You see how the various parts use various versions? this is prune to error. I could sit down and test/update the parts myself, since i am in the Uniter org. :) but i just wanted to ask for permission first.
IngwiePhoenix commented
This might help identify things:
Ingwie@Ingwies-Macbook-Pro.local ~/Work $ npm ls | grep "php"
├─┬ phpruntime@4.1.0
│ ├─┬ phpcommon@1.3.0
│ ├─┬ phpcore@3.9.1
│ ├── phptoast@2.3.0
│ └─┬ phptojs@2.1.0
├─┬ phptoast@3.10.0
│ └── phpcommon@1.3.0
└─┬ phptojs@3.8.0
├── phpcommon@1.3.0
asmblah commented
Hi @IngwiePhoenix,
I've bumped the versions in phpruntime
so you should only get one copy of each dependency now. For example, uniter
gets
uniter [master] $ npm ls | grep php
├─┬ phpcommon@1.3.0
├─┬ phpruntime@4.1.1
│ └─┬ phpcore@3.9.1
├─┬ phptoast@3.10.0
├─┬ phptojs@3.8.0
with
"phpcommon": "~1.3",
"phpruntime": "~4",
"phptoast": "~3",
"phptojs": "~3"
Cheers!
IngwiePhoenix commented
Nice! yup, indeed is fixed now. :)