asmjit/cult

Readme / CMake should enforce required C++11

breznak opened this issue · 4 comments

Building on Ubuntu with recent gcc 5.4, when I follow the basic Readme instructions the build fails as std=c++11 is not selected, but is required.

~/devel/cult/build$ make
[  2%] Building CXX object CMakeFiles/cult.dir/src/cult/app.cpp.o
In file included from /home/mmm/devel/cult/src/cult/./app.h:5:0,
                 from /home/mmm/devel/cult/src/cult/app.cpp:1:
/home/mmm/devel/cult/src/cult/././jsonbuilder.h:15:3: warning: identifier ‘noexcept’ is a keyword in C++11 [-Wc++0x-compat]
   JSONBuilder(StringBuilder* dst) noexcept;
   ^

Can you post cmake's output?

I'm interested in these lines as the C++ version should be auto-selected:

-- Performing Test __CxxFlag__std_c++14
-- Performing Test __CxxFlag__std_c++14 - Success
-- Performing Test __CxxFlag__std_c++11
-- Performing Test __CxxFlag__std_c++11 - Success
-- Performing Test __CxxFlag__std_c++0x
-- Performing Test __CxxFlag__std_c++0x - Success

Well, I think I see the problem now, I will fix it.

Please pull asmjit and cult and try again, it should be resolved by now.

Yep, that fixed it! Thanks 👍