aspecto-io/opentelemetry-ext-js

Socket.io: `connection` should be a reserved event

rauno56 opened this issue · 2 comments

See socketio/socket.io-website#277

The docs don't say that and maybe the maintainers have a good reason here, but, conceptually, if disconnect and disconnecting are reserved, so is connection.

If I understood this conversation correctly, potentially, a client could emit a connection event.
So we should treat the connection as a reserved event only when instrumenting the Server instance and not the Socket.

and looks like we need to also treat new_namespace as reserved for the Server, right?