aspecto-io/opentelemetry-ext-js

sequelize instrumentation: authenticate and sync are creating orphaned spans

blumamir opened this issue · 0 comments

Those 2 functions are executing queries on the database.
The queries create sequelize spans that are missing the context of what happened:

  • If called on startup without an active trace, they will just be generated as a single-span-trace which is lacking any clue about what caused it and why it was created (the query is something like SELECT 1+1 AS result)
  • If called while there is an active trace, then the trace will have those span as child of some other span which can also be confusing.

I suggest to instrument these functions as well, so the instrumentation user will know that a call to authenticate or model.sync happened.