Refactor DI support in DataProtection

Question

Refactor DI support in DataProtection

ajaybhargavb opened this issue 9 years ago · 10 comments

ajaybhargavb commented 9 years ago

Answer 1 · 2016-04-05T16:08:56.000Z

@ajaybhargavb How close is this for check-in?

@Eilon Are we taking this in RC2? Or postpone to 1.0.0?

Answer 2 · 2016-04-05T17:33:08.000Z

I'll be sending an update to the PR today. But it will not include and test and documentation changes.

Answer 3 · 2016-04-06T20:34:48.000Z

I'd like to get this for RC2 because there are public API changes in it, and I spoke to @ajaybhargavb about it and we had a short email thread too.

Answer 4 · 2016-04-21T21:00:26.000Z

Looks like the PR is a little stale at the moment. Do we have any blockers on this?

Answer 5 · 2016-04-21T21:44:08.000Z

Spoke to @Eilon and @rynowak this morning. This is being moved to RTM.

Answer 6 · 2016-10-24T23:54:45.000Z

The latest code and samples are in https://github.com/aspnet/DataProtection/tree/ajbaaska/new-dataprotection branch.

Answer 7 · 2016-10-26T14:01:26.000Z

@ajaybhargavb You're working on the DI bits, right? I ask because I was having a small problem with DI into the XmlDecryptor. #154

The problem was that DI for XmlDecryptor wasn't working. I wanted to do this ...

public CustomXmlDecryptor(IOptions<CustomDataProtectionOptions> dataProtectionOptions)
{
    _key = dataProtectionOptions.Value.Key;
}

... but that wasn't working. I simply wasn't getting the value. It works using the ctor injection pattern for XmlEncryptor, just not for XmlDecryptor.

With a little help from @tillig, I was able to make it work on the decryptor side with a little hack, I ended up having to do this ...

public CustomXmlDecryptor(IServiceProvider services)
{
    var dataProtectionOptions = 
        services.GetRequiredService<IOptions<CustomDataProtectionOptions>>();
    _key = dataProtectionOptions.Value.Key;
}

Is fixing this something that falls under this issue, or was this problem already addressed do you know?

Answer 8 · 2016-10-26T14:42:41.000Z

@guardrex - please make a separate issue for this. Having looked at the code, this isn't something that's been supported so far so it's a feature request

Answer 9 · 2016-10-26T14:43:31.000Z

@rynowak Ok, thanks. Will do.

Answer 10 · 2016-10-26T17:39:21.000Z

I reopened and re-titled that issue ... it basically describes the difference in success using DI with the ctors of IXmlDecryptor and IXmlEncryptor. Given the workaround there, I'm not blocked of course, so it really is just a nice-to-have if you like the idea.

#154