Idea to minimize buffer allocations in PhysicalFileProvider

Question

Idea to minimize buffer allocations in PhysicalFileProvider

davidfowl opened this issue 9 years ago · 7 comments

davidfowl commented 9 years ago

Credit goes to @stephentoub

Pass the minimum buffer size (1) to the FileStream constructor and have callers use pooled buffers for reading.

/cc @pakrym @Tratcher @rynowak

Answer 1 · 2016-07-21T04:10:20.000Z

Would it read skipping internal buffer in this case?

Answer 2 · 2016-07-21T04:10:32.000Z

That's the idea.

Answer 3 · 2016-07-21T04:10:56.000Z

I'll try and profile it tomorrow.

Answer 4 · 2016-07-21T04:11:18.000Z

Would be nice to allow passing 0 to bufferSize then.

Answer 5 · 2016-07-21T04:25:45.000Z

While it may be nice aesthetically, it shouldn't really impact anything. The buffer shouldn't be allocated (at least not in corefx), as the buffer is lazily-initialized and will be skipped if the number of bytes to be read is >= bufferSize.

Answer 6 · 2016-07-26T16:19:52.000Z

@pakrym did it help (if you got the chance to profile)?

Answer 7 · 2016-07-26T16:24:12.000Z

Yes, I implemented it. Buffer allocations from FileStream are not a problem anymore.