Precompiled views don't work for relative paths

Question

Precompiled views don't work for relative paths

Closed this issue 7 years ago · 16 comments

jhudsoncedaron commented 7 years ago

On running dotnet publish I get a *.PrecompiledViews.dll and no refs folder.

On running dotnet publish -r win7-x64 I get no *.PrecopmiledViews.dll and a refs folder.

I tried copying the *.PrecompiledViews.dll from one to the other but it didn't work.

Answer 1 · 2018-01-12T17:36:02.000Z

@pranavkm, what is the expected behavior here?

Answer 2 · 2018-01-12T17:38:16.000Z

Expected: dotnet publish -r win7-x64 should yield *.PrecompiledViews.dll and no refs folder.

Answer 3 · 2018-01-12T17:52:42.000Z

We specifically disabled precompilation for self contained apps in 2.0. #102 (comment) has some guidance on what you could do workaround this. The issue is addressed as part of 2.1.0-preview1 release.

Answer 4 · 2018-01-12T19:31:38.000Z

That workaround definitely does not work. Excluding the views and providing *.PrecompiledViews.dll just results in "View not found" being spammed to the log file.

Answer 5 · 2018-01-12T22:14:31.000Z

Do you have a repro app for this? We've been recommending the copying behavior for a while now and it's worked for most users.

Answer 6 · 2018-01-12T22:20:49.000Z

I have an application that reliably reproduces it but I can't publish it here. At this point our team plan is to try the 2.1 version of .NET Core (which will take some effort) before we see if we can reduce this out. I was able to try the workaround quickly because it merely involved copying a few files around.

Answer 7 · 2018-01-16T17:18:15.000Z

@pranavkm : I couldn't find an official preview release, and the nightly builds currently ship with an MVC Razor that doesn't work. I filed the bug in core itself because the template mvc project doesn't work. dotnet/core#1221

Answer 8 · 2018-01-16T17:42:23.000Z

@jhudsoncedaron, unfortunately we won't be able to help you without a repro. If you could share with us a minimalistic repro project, with all the "sensitive" stuff stripped out, that would be great.

Answer 9 · 2018-01-16T18:00:01.000Z

@jhudsoncedaron the issue is a runtime issue. Updating to the most recent Microsoft.AspNetCore.All runtime (https://github.com/aspnet/Universe#daily-builds) should resolve the issue

Answer 10 · 2018-01-16T19:17:17.000Z

I'm sorry. I don't actually understand razor views very well and am blundering around. I have successfully determined the following: The workaround doesn't work when the view references another view with '..' in the reference path.

Answer 11 · 2018-01-16T20:14:19.000Z

@jhudsoncedaron when you say reference, is this when you're attempting to do something along the lines of Html.Partial("../_Partial") or Layout = "../Layout"? We did have a couple of issues around this that we fixed as part of aspnet/Mvc#6676, but perhaps you're run in to a scenario we didn't fix cover. What does the calling code look like - that should give us something we could help you with.

Answer 12 · 2018-01-17T15:42:50.000Z

I constructed a (silly) reproduction from the empty template using Html.Partial.

build project with
dotnet publish
dotnet publish -r win7-x64
cd bin\debug\netcoreapp2.0\win7-x64\publish
mklink emptymvc20.PrecompiledViews.dll ....\publish\emptymvc20.PrecompiledViews.dll
rmdir /s Views

Run with
emptymvc20.exe

Open http://localhost:5000; see that the page loads.
Open http://localhost:5000/T1; see that the page loads.
Open http://localhost:5000/T2; see the error and the long stack trace

cd ..\..\..\..\..
dotnet run

Open http://localhost:5000/T2; see that the page loads.

emptymvc20.zip

Answer 13 · 2018-01-17T15:55:19.000Z

Thanks @jhudsoncedaron. I'll have a look.

Answer 14 · 2018-01-17T15:57:50.000Z

I tried it on the nightly builds but ASP .NET nightly builds are still broken as of today's build 2.2.0-previwe1-007947 retrieved from https://github.com/dotnet/cli/blob/master/README.md

Answer 15 · 2018-01-22T19:18:07.000Z

@jhudsoncedaron, the issue is fixed in 2.1.0-preview1. Here's the change to your csproj you can use to verify the change:

// emptymvc20.csproj
<Project Sdk="Microsoft.NET.Sdk.Web">

  <PropertyGroup>
    <TargetFramework>netcoreapp2.0</TargetFramework>
    <RestoreSources>https://api.nuget.org/v3/index.json;https://dotnet.myget.org/f/aspnetcore-dev/api/v3/index.json</RestoreSources>
  </PropertyGroup>

  <ItemGroup>
    <PackageReference Include="Microsoft.AspNetCore.All" Version="2.0.0" />
    <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor" Version="2.1.0-preview1-28137" />
  </ItemGroup>

</Project>

For the 2.0 release, here's some past discussion around this area: aspnet/Mvc#6672 (comment). Tl;dr: use @Html.Partial("../T1/Index.cshtml", null). That should cause Mvc to treat it as a path instead of a name and running in to the issue you're running it now.

Answer 16 · 2018-01-22T19:18:31.000Z

Dup of aspnet/Mvc#6672